diff options
Diffstat (limited to 'lib/plugins/sortPlugins.js')
-rw-r--r-- | lib/plugins/sortPlugins.js | 34 |
1 files changed, 17 insertions, 17 deletions
diff --git a/lib/plugins/sortPlugins.js b/lib/plugins/sortPlugins.js index e96b02c..155b691 100644 --- a/lib/plugins/sortPlugins.js +++ b/lib/plugins/sortPlugins.js @@ -1,12 +1,19 @@ +var Immutable = require('immutable'); + var THEME_PREFIX = require('../constants/themePrefix'); -var LOADING_ORDER = ['plugin', 'theme']; + +var TYPE_PLUGIN = 'plugin'; +var TYPE_THEME = 'theme'; + /** * Returns the type of a plugin given its name + * @param {Plugin} plugin * @return {String} */ -function pluginType(name) { - return (name && name.indexOf(THEME_PREFIX) === 0) ? 'theme' : 'plugin'; +function pluginType(plugin) { + var name = plugin.getName(); + return (name && name.indexOf(THEME_PREFIX) === 0) ? TYPE_THEME : TYPE_PLUGIN; } @@ -15,22 +22,15 @@ function pluginType(name) { * The themes should always be loaded after the plugins * * @param {<OrderedMap<String:Plugin>>} plugins - * @param {<List<String>>} requirementsKeys * @return {OrderedMap<String:Plugin>} */ -function sortPlugins(plugins, requirementsKeys) { - // Sort plugins to match list in book.json - return plugins.sort(function(a, b) { - // Get order from book.json - var definitionOrder = requirementsKeys.indexOf(a.getName()) < requirementsKeys.indexOf(b.getName()); - - // Get order from plugins a and b type - var aType = pluginType(a.getName()), - bType = pluginType(b.getName()), - loadingOrder = LOADING_ORDER.indexOf(aType) < LOADING_ORDER.indexOf(bType); - - return loadingOrder || definitionOrder ? -1 : 1; - }); +function sortPlugins(plugins) { + var byTypes = plugins.groupBy(pluginType); + + return byTypes.get(TYPE_PLUGIN, Immutable.OrderedMap()) + .merge( + byTypes.get(TYPE_THEME, Immutable.OrderedMap()) + ); } module.exports = sortPlugins;
\ No newline at end of file |