diff options
author | Samy Pessé <samypesse@gmail.com> | 2016-04-25 11:28:21 +0200 |
---|---|---|
committer | Samy Pessé <samypesse@gmail.com> | 2016-04-25 11:28:21 +0200 |
commit | e1e4e7f01177d968e63f0b3a1830eda1adacb56b (patch) | |
tree | de1864bac7bce3f7e0c3a881b70e899a563347da /lib/output/modifiers | |
parent | 814b6ff489bc1f0bfd03db6409d49185e8c7b93e (diff) | |
download | gitbook-e1e4e7f01177d968e63f0b3a1830eda1adacb56b.zip gitbook-e1e4e7f01177d968e63f0b3a1830eda1adacb56b.tar.gz gitbook-e1e4e7f01177d968e63f0b3a1830eda1adacb56b.tar.bz2 |
Add tests for link resolution
Diffstat (limited to 'lib/output/modifiers')
-rw-r--r-- | lib/output/modifiers/__tests__/resolveLinks.js | 60 | ||||
-rw-r--r-- | lib/output/modifiers/resolveLinks.js | 4 |
2 files changed, 62 insertions, 2 deletions
diff --git a/lib/output/modifiers/__tests__/resolveLinks.js b/lib/output/modifiers/__tests__/resolveLinks.js index 36511a2..3d50d80 100644 --- a/lib/output/modifiers/__tests__/resolveLinks.js +++ b/lib/output/modifiers/__tests__/resolveLinks.js @@ -1,10 +1,70 @@ jest.autoMockOff(); +var path = require('path'); var cheerio = require('cheerio'); describe('resolveLinks', function() { var resolveLinks = require('../resolveLinks'); + function resolveFileBasic(href) { + return href; + } + + function resolveFileCustom(href) { + if (path.extname(href) == '.md') { + return href.slice(0, -3) + '.html'; + } + + return href; + } + + describe('Absolute path', function() { + var TEST = '<p>This is a <a href="/test/cool.md"></a></p>'; + + pit('should resolve path starting by "/" in root directory', function() { + var $ = cheerio.load(TEST); + + return resolveLinks('hello.md', resolveFileBasic, $) + .then(function() { + var link = $('a'); + expect(link.attr('href')).toBe('test/cool.md'); + }); + }); + + pit('should resolve path starting by "/" in child directory', function() { + var $ = cheerio.load(TEST); + + return resolveLinks('afolder/hello.md', resolveFileBasic, $) + .then(function() { + var link = $('a'); + expect(link.attr('href')).toBe('../test/cool.md'); + }); + }); + }); + + describe('Custom Resolver', function() { + var TEST = '<p>This is a <a href="/test/cool.md"></a> <a href="afile.png"></a></p>'; + + pit('should resolve path correctly for absolute path', function() { + var $ = cheerio.load(TEST); + + return resolveLinks('hello.md', resolveFileCustom, $) + .then(function() { + var link = $('a').first(); + expect(link.attr('href')).toBe('test/cool.html'); + }); + }); + + pit('should resolve path correctly for absolute path (2)', function() { + var $ = cheerio.load(TEST); + + return resolveLinks('afodler/hello.md', resolveFileCustom, $) + .then(function() { + var link = $('a').first(); + expect(link.attr('href')).toBe('../test/cool.html'); + }); + }); + }); }); diff --git a/lib/output/modifiers/resolveLinks.js b/lib/output/modifiers/resolveLinks.js index b5ad4f3..bf3fd10 100644 --- a/lib/output/modifiers/resolveLinks.js +++ b/lib/output/modifiers/resolveLinks.js @@ -17,13 +17,13 @@ function resolveLinks(currentFile, resolveFile, $) { return editHTMLElement($, 'a', function($a) { var href = $a.attr('href'); - if (location.isExternal(href)) { + if (LocationUtils.isExternal(href)) { $a.attr('_target', 'blank'); return; } // Calcul absolute path for this - href = LocationUtils.toAbsolute(href, currentDirectory, currentDirectory); + href = LocationUtils.toAbsolute(href, currentDirectory, '.'); // Resolve file href = resolveFile(href); |