diff options
| author | matt <matt@twilio.com> | 2016-08-29 10:39:08 -0700 |
|---|---|---|
| committer | matt <matt@twilio.com> | 2016-08-29 10:39:08 -0700 |
| commit | bcf66baa81d5412fec65bf46f81435e59f3fadde (patch) | |
| tree | 2a01ddaa7245e3ac913edc9bd4fc1cba2b0d3e71 /Twilio/Tests/Integration/Lookups/V1/PhoneNumberTest.php | |
| parent | 1b5fe25928f904846d58d914bc259dc9865ab9fd (diff) | |
| download | twilio-php-origin/urlencode-url-parts.zip twilio-php-origin/urlencode-url-parts.tar.gz twilio-php-origin/urlencode-url-parts.tar.bz2 | |
rawurlencode solution arguments before interpolationorigin/urlencode-url-parts
- URL segments are generally sids, but in the case that they are phone
numbers or sid-likes, they should be `rawurlencode()`d
- Updates the Holodeck assertions so they produce better failure messages.
- Updates appropriate tests to assert correct behavior.
Diffstat (limited to 'Twilio/Tests/Integration/Lookups/V1/PhoneNumberTest.php')
| -rw-r--r-- | Twilio/Tests/Integration/Lookups/V1/PhoneNumberTest.php | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/Twilio/Tests/Integration/Lookups/V1/PhoneNumberTest.php b/Twilio/Tests/Integration/Lookups/V1/PhoneNumberTest.php index 73b4fd2..1c5060e 100644 --- a/Twilio/Tests/Integration/Lookups/V1/PhoneNumberTest.php +++ b/Twilio/Tests/Integration/Lookups/V1/PhoneNumberTest.php @@ -24,10 +24,10 @@ class PhoneNumberTest extends HolodeckTestCase { } catch (DeserializeException $e) {} catch (TwilioException $e) {} - $this->assertTrue($this->holodeck->hasRequest(new Request( + $this->assertRequest(new Request( 'get', - 'https://lookups.twilio.com/v1/PhoneNumbers/+987654321' - ))); + 'https://lookups.twilio.com/v1/PhoneNumbers/%2B987654321' + )); } public function testFetchResponse() { |