rawurlencode solution arguments before interpolationorigin/urlencode-url-parts

  - URL segments are generally sids, but in the case that they are phone
     numbers or sid-likes, they should be `rawurlencode()`d
  - Updates the Holodeck assertions so they produce better failure messages.
  - Updates appropriate tests to assert correct behavior.

1 files changed, 9 insertions, 9 deletions

diff --git a/Twilio/Tests/Integration/Api/V2010/AccountTest.php b/Twilio/Tests/Integration/Api/V2010/AccountTest.php
index f47b08d..1077a06 100644
--- a/Twilio/Tests/Integration/Api/V2010/AccountTest.php
+++ b/Twilio/Tests/Integration/Api/V2010/AccountTest.php
@@ -24,10 +24,10 @@ class AccountTest extends HolodeckTestCase {
         } catch (DeserializeException $e) {}
           catch (TwilioException $e) {}
         
-        $this->assertTrue($this->holodeck->hasRequest(new Request(
+        $this->assertRequest(new Request(
             'post',
             'https://api.twilio.com/2010-04-01/Accounts.json'
-        )));
+        ));
     }
 
     public function testCreateResponse() {
@@ -73,10 +73,10 @@ class AccountTest extends HolodeckTestCase {
         } catch (DeserializeException $e) {}
           catch (TwilioException $e) {}
         
-        $this->assertTrue($this->holodeck->hasRequest(new Request(
+        $this->assertRequest(new Request(
             'get',
             'https://api.twilio.com/2010-04-01/Accounts/ACaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.json'
-        )));
+        ));
     }
 
     public function testFetchResponse() {
@@ -122,10 +122,10 @@ class AccountTest extends HolodeckTestCase {
         } catch (DeserializeException $e) {}
           catch (TwilioException $e) {}
         
-        $this->assertTrue($this->holodeck->hasRequest(new Request(
+        $this->assertRequest(new Request(
             'get',
             'https://api.twilio.com/2010-04-01/Accounts.json'
-        )));
+        ));
     }
 
     public function testReadFullResponse() {
@@ -183,7 +183,7 @@ class AccountTest extends HolodeckTestCase {
         
         $actual = $this->twilio->api->v2010->accounts->read();
         
-        $this->assertTrue(count($actual) > 0);
+        $this->assertGreaterThan(0, count($actual));
     }
 
     public function testReadEmptyResponse() {
@@ -220,10 +220,10 @@ class AccountTest extends HolodeckTestCase {
         } catch (DeserializeException $e) {}
           catch (TwilioException $e) {}
         
-        $this->assertTrue($this->holodeck->hasRequest(new Request(
+        $this->assertRequest(new Request(
             'post',
             'https://api.twilio.com/2010-04-01/Accounts/ACaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.json'
-        )));
+        ));
     }
 
     public function testUpdateResponse() {